Re: [PATCH] I2C patch 2 - break up the SMBus formatting

From: Greg KH
Date: Fri Feb 25 2005 - 16:55:09 EST


On Thu, Feb 24, 2005 at 05:27:25PM -0600, Corey Minyard wrote:
> This is one in a series of patches for adding a non-blocking interface
> to the I2C driver for supporting the IPMI SMBus driver.

> This patch reorganizes the formatting code to make it more
> suitable for the upcoming non-blocking changes. It also adds
> an op queue entry that is used to pass data around (for now)
> and will be used for queueing in the non-blocking case.

Hm, ick. Can you break this up into 2 pieces? One that reorders the
formatting of the code, and then one that adds the new functionality?
Otherwise it's very hard to follow the changes that are happening in
here.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/