Re: [2.6 patch] unexport do_settimeofday

From: Arjan van de Ven
Date: Sat Feb 26 2005 - 05:03:45 EST


On Fri, 2005-02-25 at 15:20 -0800, Andrew Morton wrote:
> Adrian Bunk <bunk@xxxxxxxxx> wrote:
> >
> > > +#ifdef MODULE
> > > +#define __deprecated_in_modules __deprecated
> > > +#else
> > > +#define __deprecated_in_modules /* OK in non-modular code */
> > > +#endif
> > > +
> > >...
> >
> > Looks good.
> >
> >
> > One more question:
> >
> > You get a false positive if the file containing the symbol is itself a
> > module.
>
> I don't understand what you mean.
>
> You mean that a module is doing an EXPORT_SYMBOL of a symbol which is on
> death row?
>
> If so: err, not sure. I guess we could just live with the warning.

also those should be rare; it's certainly not a "core" export that 3rd
party stuff depends on but most of the time just accidentally exported
(by people who thought that they needed EXPORT_SYMBOL to glue two .c
files into the same one .o module)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/