Re: [PATCH] partitions/msdos.c

From: Uwe Bonnes
Date: Sat Feb 26 2005 - 19:50:31 EST


>>>>> "Linus" == Linus Torvalds <torvalds@xxxxxxxx> writes:

Linus> On Sun, 27 Feb 2005, Andries Brouwer wrote:
>> (Concerning the "size" version: it occurred to me that there is one
>> very minor objection: For extended partitions so far the size did not
>> normally play a role. Only the starting sector was significant. If,
>> at some moment we decide also to check the size, then a weaker check,
>> namely only checking for non-extended partitions, might be better at
>> first.)

Linus> Yes. I agree - checking the size is likely _more_ dangerous and
Linus> likely to break something silly than checking the ID for zero.

Linus> So your patch it is. I'll put it in immediately after doing a
Linus> 2.6.11 (no need to worry about getting into 2.6.11, since afaik
Linus> the worst problem right now is an extra partition that isn't
Linus> usable).

Well,

on a Suse 9.2 System with Suse Hotplug, the phantom partition was somehow
recognized as Reiserfs, and then the Hotplug mechanism trying to mount the
bogus partition as a Reiser Filesystem ended in an Oops...

--
Uwe Bonnes bon@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/