Re: [PATCH] PPC64: Generic hotplug cpu support

[Benjamin Herrenschmidt]

On Sun, 2005-02-27 at 03:16 -0800, Andrew Morton wrote:
> Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx> wrote:
> >
> > Patch provides a generic hotplug cpu implementation, with the only current 
> >  user being pmac.
> 
> BUG: using smp_processor_id() in preemptible [00000001] code: swapper/0
> caller is .native_idle+0x30/0x60
> 
> --- 25/arch/ppc64/kernel/idle.c~ppc64-generic-hotplug-cpu-support-fix	2005-02-27 11:12:47.000000000 -0700
> +++ 25-akpm/arch/ppc64/kernel/idle.c	2005-02-27 11:13:03.000000000 -0700
> @@ -294,7 +294,7 @@ static int native_idle(void)
>  		if (need_resched())
>  			schedule();
>  
> -		if (cpu_is_offline(smp_processor_id()) &&
> +		if (cpu_is_offline(_smp_processor_id()) &&
>  		    system_state == SYSTEM_RUNNING)
>  			cpu_die();
>  	}
> _

This is the idle loop. Is that ever supposed to be preempted ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/