Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

From: Russell King
Date: Mon Feb 28 2005 - 08:30:20 EST


On Mon, Feb 28, 2005 at 02:13:57PM +0100, colbuse@xxxxxxxxxxxxxxx wrote:
> NPAR times :-). As I stated, npar is unsigned.

I think that's disgusting then - it isn't obvious what's going on, which
leads to mistakes.

For the sake of a micro-optimisation such as this, it's far more important
that the code be readable and easily understandable.

Others may disagree.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/