Re: SPARC64: Modular floppy?

From: Horst von Brand
Date: Tue Mar 01 2005 - 14:29:33 EST


"Randy.Dunlap" <rddunlap@xxxxxxxx> said:
> Horst von Brand wrote:
> > "David S. Miller" <davem@xxxxxxxxxxxxx> said:
> >>On Mon, 28 Feb 2005 17:07:43 -0300
> >>Horst von Brand <vonbrand@xxxxxxxxxxxx> wrote:

> > [...]

> >>>So, either the dependencies have to get fixed so floppy can't be modular
> >>>for this architecture, or the relevant functions have to move from entry.S
> >>>to the module.

> >>I think the former is the best solution. The assembler code really
> >>needs to get at floppy.c symbols.

> >>From my cursory look the stuff depending on the floppy.c symbols is just
> > in the floppy-related code. Can't that be just included in floppy.c?
> > (Could be quite a mess, but it looks like short stretches).

> The code in entry.S looks self-contained (to me:), so moving it
> somewhere else should just be a SMOP (mostly kbuild stuff)....

Right. But where? I was thinking under arch/sparc64/drivers/floppy.S or
such. And then there would need to be some make magic for it to get picked
up and included only for sparc64. Sounds doable, if somewhat messy.

But thinking a bit farther, if every arch and random driver starts playing
this kind of games, we'll soon be in a world of hurt. Not sure if it is
worth it.

Other solution was to #ifdef that stuff into floppy.c, but again at the
end of that way lies madness.

I'll see what I come up with. Recomended reading on the whole kbuild stuff?
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/