Re: [patch 1/1] kernel/smp: replace schedule_timeout() with ssleep()

[Pavel Machek]

Hi!

> Use ssleep() instead of schedule_timeout(). The original code uses
> TASK_INTERRUPTIBLE, but does not check for signals, so I believe the change to
> ssleep() is appropriate.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> Signed-off-by: Domen Puncer <domen@xxxxxxxxxxxx>

Actually this code should be rewritten to use cpu hotplug
infrastructure, but this seems simple enough. ACK. [Heh, would be nice
if someone could test it...]

							Pavel

> diff -puN kernel/power/smp.c~ssleep-kernel_power_smp kernel/power/smp.c
> --- kj/kernel/power/smp.c~ssleep-kernel_power_smp	2005-03-05 16:11:19.000000000 +0100
> +++ kj-domen/kernel/power/smp.c	2005-03-05 16:11:19.000000000 +0100
> @@ -13,6 +13,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/suspend.h>
>  #include <linux/module.h>
> +#include <linux/delay.h>
>  #include <asm/atomic.h>
>  #include <asm/tlbflush.h>
>  
> @@ -49,8 +50,7 @@ void disable_nonboot_cpus(void)
>  	printk("Freezing CPUs (at %d)", smp_processor_id());
>  	oldmask = current->cpus_allowed;
>  	set_cpus_allowed(current, cpumask_of_cpu(0));
> -	current->state = TASK_INTERRUPTIBLE;
> -	schedule_timeout(HZ);
> +	ssleep(1);
>  	printk("...");
>  	BUG_ON(smp_processor_id() != 0);
>  
> _

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/