Re: [PATCH] Restore PWC driver

From: Christoph Hellwig
Date: Tue Mar 08 2005 - 00:41:19 EST


On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote:
> Ick, Alan, couldn't you have had the decency to run this through the USB
> developers, and at least pinged me on it? Especially due to all of the
> hate-email I have gotten over this driver in the past.
>
> As it is, the coding style sucks in places, and you didn't really need
> to make it a new subdirectory (although due to the increased size of the
> driver, it's probably better now...)
>
> And, there's no MAINTAINERS entry for who I need to bug about this
> thing.

Agree with greg on all these bits, and similar (although not as bad) for
the other bits Alan sent. Alan, could you please go through the subsystem
maintainer & -mm process like everyone else? A little public review
can't hurt your patches either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/