Race against parent deletion in key_user_lookup()

From: Alexander Nyberg
Date: Wed Mar 09 2005 - 06:22:11 EST

I looked at some of the oops reports against keyrings, I think the problem
is that the search isn't restarted after dropping the key_user_lock,
*p will still be NULL when we get back to try_again and look through the tree.

It looks like the intention was that the search start over from scratch.

Signed-off-by: Alexander Nyberg <alexn@xxxxxxxxx>

===== security/keys/key.c 1.5 vs edited =====
--- 1.5/security/keys/key.c 2005-01-21 06:02:10 +01:00
+++ edited/security/keys/key.c 2005-03-09 12:04:54 +01:00
@@ -57,9 +57,10 @@ struct key_user *key_user_lookup(uid_t u
struct key_user *candidate = NULL, *user;
struct rb_node *parent = NULL;
- struct rb_node **p = &key_user_tree.rb_node;
+ struct rb_node **p;

+ p = &key_user_tree.rb_node;

/* search the tree for a user record with a matching UID */

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/