Re: [PATCH 2/2] readahead: improve sequential read detection

From: Steven Pratt
Date: Wed Mar 09 2005 - 19:12:09 EST

Ram wrote:

On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:


@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac

- return newsize;
+ return ra->prev_page + 1;

This change introduces one key behavioural change in
page_cache_readahead(). Instead of returning the number-of-pages
successfully read, it now returns the next-page-index which is yet to be
read. Was this essential?

and unless filmap.c was changed accordingly this is broken.. need. to look at this more.


At least, a comment towards this effect at the top of the function is
worth adding.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at