Re: [PATCH 0/15] ptwalk: pagetable walker cleanup

From: Benjamin Herrenschmidt
Date: Wed Mar 09 2005 - 20:50:05 EST


On Wed, 2005-03-09 at 17:02 -0800, David S. Miller wrote:
> On Thu, 10 Mar 2005 11:39:44 +1100
> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > There are some other bugs introduced by set_pte_at() caused by latent
> > bugs in the PTE walkers that 'drop' part of the address along the way,
> > notably the vmalloc.c ones are bogus, thus breaking ppc/ppc64 in subtle
> > ways. Before I send patches, I'd rather check if it's not all fixed by
> > your patches first :)
>
> Ben, I fixed vmalloc and the other cases when I pushed the set_pte_at()
> changes to Linus. Here is the changeset that fixes them, and it's certainly
> in Linus's tree:

Yah, but look at the cruft in arch/ppc64/mm/init.c, specifically,
unmap_im_area_{pte,pmd,pud,..} ...

I'll fix it.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/