Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

From: David Howells
Date: Thu Mar 10 2005 - 07:51:46 EST

Andrew Morton <akpm@xxxxxxxx> wrote:

> What's with the preempt_enable()/disable() added to __key_link()? It's not
> obvious what is being protected from what, and why.

Ummm... Yes... They're probably not necessary. A wmb() may be required after
the klist->nkeys++ to commit to memory the fact there's now an extra key link
available, but I'm not sure that it's necessary.

Do you want me to redo the patch?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at