Re: [PATCH] realtime-preempt: update inherited priorities on setscheduler

From: Scott Wood
Date: Fri Mar 11 2005 - 11:23:42 EST


On Fri, Mar 11, 2005 at 10:36:07AM +0100, Ingo Molnar wrote:
>
> * Scott Wood <scott@xxxxxxxxxxxxxx> wrote:
>
> > - p->prio = effective_prio(p);
> > + /* Don't overwrite an inherited RT priority with the static
> > + RT priority. */
> > +
> > + if (!rt_task(p))
> > + p->prio = effective_prio(p);
>
> are you sure this is needed? The -RT code currently does this:
>
> static int effective_prio(task_t *p)
> {
> if (rt_task(p))
> return p->prio;
> return __effective_prio(p);
> }

I must have read-then-misremembered it as recalculating the prio from
rt_priority, or else been worried about some race that doesn't appear
possible. The change isn't needed.

-Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/