Re: [PATCH] PPC64 NUMA memory fixup
From: mike kravetz
Date: Fri Mar 11 2005 - 12:33:06 EST
On Fri, Mar 11, 2005 at 07:51:38PM +1100, Paul Mackerras wrote:
> Anyway, the ultimate reason seems to be that the numa.c code is
> assuming that an address value and a size value occupy the same number
> of cells. On the G5 we have #address-cells = 2 but #size-cells = 1.
> Previously this didn't matter because we used the values in lmb.memory
> for the free_bootmem_node calls. Those values are obtained in prom.c
> by scanning the memory nodes, using the correct number of cells. With
> Mike's patch we rely instead on the values obtained by the numa.c
> code, which uses read_cell_ul() for both address and size values, and
> that just uses prom_n_size_cells() to know how many cells to parse.
> It really needs to use prom_n_addr_cells() when parsing an address
Thanks Paul!!! That was more than I expected when I asked if you
could recreate on your G5 and provide me more info for analysis.
I'll work on creating a new version of the patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/