Re: [2.6 patch] drivers/pnp/: possible cleanups

From: Adrian Bunk
Date: Sat Mar 12 2005 - 12:10:13 EST

On Fri, Mar 11, 2005 at 07:44:56PM -0500, Adam Belay wrote:
> On Fri, 2005-03-11 at 16:23 -0800, Andrew Morton wrote:
> > Adam Belay <abelay@xxxxxxxxxx> wrote:
> > >
> > > This patch essential makes it impossible for PnP protocols to be
> > > modules. Currently, they are all in-kernel. If that is acceptable...,
> > > then this patch looks fine to me. Any comments?
> >
> > You're the maintainer...
> I've been holding off on making many changes to PnP at the moment,
> because I have been considering replacing it with a new (more modern and
> ACPI capable) ISA/LPC bridge driver. This work would likely begin after
> my PCI bridge driver rewrite is finished and merged (as the PCI work is
> in some ways a prerequisite).
> Still, if there are changes to fix actual bugs, then I'm all for them.
> Also a few features could be added. Specifically PnPBIOS
> hotplug/docking station support. If anyone's interested, I may
> implement it (and it would use some functions that were removed by this
> patch). Furthermore, ISAPnP could be made a module. PnPBIOS probably
> couldn't.

Note that my patch #if 0's exactly one functions and removes no
functions. Most it does is the removal of EXPORT_SYMBOL's, so if any
modular code will use any of them, re-adding will be trivial.

Modular ISAPnP might be interesting in some cases, but this is more
legacy code. If someone would work on it to sort all the issues out
(starting with the point that most users of __ISAPNP__ will have to be
fixed) re-adding the required EXPORT_SYMBOL's won't be hard for him.

> Thanks,
> Adam



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at