Re: [PATCH][-mm][1/2] cifs: whitespace cleanups for file.c

From: Steve French
Date: Mon Mar 14 2005 - 11:00:23 EST

On Mon, 2005-03-14 at 09:36, Jesper Juhl wrote:

> Would it be useful if I split the second patch into a few parts for you? I
> could split some of the (non cifs_open related) whitespace changes into
> one, the kfree related changes into another and then a third with the
> cifs_open rework. Would that make things easier for you?

For the second patch (the one I did not apply) slightly smaller would
make things easier. For patches that have non-trivial changes - my
preference is to split the patches into the 50-200 line range since they
can be reviewed and put in incrementally.

> I may be able to install windows in vmware or borrow a machine
WindowsXP, Linux/Samba3, LinuxSamba4, Windows2000, Windows2003, etc.
have been very easy to get a hold of and test.

I have been having a very hard time getting a usable WindowsNT
(and Windows9x) server for testing (I do have one of each at work I can test
against but at home it makes it tough to test). With the latest vmware, my
last shot at NT4 install failed (not sure why yet - perhaps NT4 does
not like vmware emulated SCSI and wants IDE only) - at work we have NT4
in the older vmware working fine but I want to test it on NT4 and Win9x/WinME more,
since they get run the least and are much worse servers than Windows200x, XP and Samba
so test feedback on those on current kernel would be useful.l

Also there are other CIFS server out there - at Connectathon a few weeks ago
the testing was very helpful. Compensating for the minor differences among the
server like NetApp, BlueArc, AIX FastConnect etc. is important - and I don't have
those servers easily accessible to test against. I am especially interested
in test feedback with current kernel/cifs against those with other
servers (not just the usual Samba3, Samba4, current Windows).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at