Re: 2.6.11-mm3 breaks compile of drivers/char/esp.c

[Andrew Morton]

Bernhard Rosenkraenzer <bero@xxxxxxxxxxxx> wrote:
>
> drivers/char/esp.c: In function 'rs_stop':
>  drivers/char/esp.c:213: error: 'struct esp_struct' has no member named 'lock'
>  drivers/char/esp.c:219: error: 'struct esp_struct' has no member named 'lock'
>  drivers/char/esp.c: In function 'rs_start':
>  drivers/char/esp.c:230: error: 'struct esp_struct' has no member named 'lock'
>  drivers/char/esp.c:236: error: 'struct esp_struct' has no member named 'lock'

Seems that Alan's diff was missing the changes to the header file.  Like
this?

--- 25/include/linux/hayesesp.h~esp-build-fix	2005-03-14 20:31:18.000000000 -0800
+++ 25-akpm/include/linux/hayesesp.h	2005-03-14 20:31:30.000000000 -0800
@@ -77,6 +77,7 @@ struct hayes_esp_config {
 
 struct esp_struct {
 	int			magic;
+	spinlock_t		lock;
 	int			port;
 	int			irq;
 	int			flags; 		/* defined in tty.h */
_
 

I didn't pick this up because ESPSERIAL is still BROKEN_ON_SMP.  Alan,
should we remove that now?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/