Re: swsusp_restore crap
From: Pavel Machek
Date: Tue Mar 15 2005 - 07:04:43 EST
> > > > Please kill that swsusp_restore() call that itself calls
> > > > flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
> > > > arch specific, and that's all swsusp_restore() does. Then, the asm just
> > > > calls this before returning to C code, so it makes no sense to have a
> > > > hook there. The x86 asm can have it's own call to some arch stuff if it
> > > > wants or just do the tlb flush in asm...
> > >
> > > Better, here is a patch... (note: flush_tlb_global() is an x86'ism,
> > > doesn't exist on ppc, thus breaks compile, and that has nothing to do in
> > > the generic code imho, it should be clearly defined as the
> > > responsibility of the asm code).
> > x86-64 needs this, too.... Otherwise it looks okay.
> It breaks compilation on i386 either, because nr_copy_pages_check
> is static in swsusp.c. May I propose the following patch instead (tested on
> x86-64 and i386)?
> +asmlinkage int __swsusp_flush_tlb(void)
> + swsusp_restore_check();
Someone will certainly forget this one, and it is probably
nicer/easier to just move BUG_ON into swsusp_suspend(), just after
restore_processor_state() or something like that...
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/