Re: PCI: remove pci_find_device usage from pci sysfs code.

From: Rolf Eike Beer
Date: Sun Mar 20 2005 - 14:48:22 EST


Greg KH wrote:
> ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, gregkh@xxxxxxx
>
> PCI: remove pci_find_device usage from pci sysfs code.

> diff -Nru a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> --- a/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00
> +++ b/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00
> @@ -481,7 +481,7 @@
> struct pci_dev *pdev = NULL;
>
> sysfs_initialized = 1;
> - while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL)
> + while ((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL)
> pci_create_sysfs_dev_files(pdev);
>
> return 0;

Any reasons why you are not using "for_each_pci_dev(pdev)" here?

Eike

Attachment: pgp00000.pgp
Description: PGP signature