Hi,-snip-
yes, i agree at that point. but, there are many people using this already and if it will _not_ become merged tobut if there is a contribution from the outside - it is not taken "as is" and maybe fixed up, whichRemember that horse in Troja? It was a gift, too.
should be nearly possible in the same time like analysing and commenting the code - it ends up
in having less supported hardware.
imho if a hardware company does indeed provide us with opensource drivers, we should take these
things as a gift, not as a "not coding guide a'like" intrusion which
has to be defeated.
of course there had been a horse in troja., but thinking like that nowadays is a bit incorrect - don't you agree?
code is reviewed normally - thats what i told before and i stated as good feature - but there is no serious reason
to blame every code to have potential "trojan horses" inside and to reject it.
I should have added a smiley.
I'm not seriously suggesting that it contains deliberate problem. But
codestyle uglyness and arbitrary limits may come back and haunt us in
future. Once code is in kernel, it is very hard to change on-disk
format, for example.
Pavel