Re: [rfc/rft] Fujitsu B-Series Lifebook PS/2 TouchScreen driver

[Andrey Panin]

On 081, 03 22, 2005 at 02:13:45AM -0500, Dmitry Torokhov wrote:
> On Monday 21 March 2005 10:31, Kenan Esau wrote:
> > Am Montag, den 21.03.2005, 09:52 -0500 schrieb Dmitry Torokhov:
> > > 
> > > There are couple of things that I an concerned with:
> > > 
> > > 1. I don't like that it overrides meaning of max_proto parameter to be
> > > exactly the protocol specified. 
> > 
> > Yeah -- I agree. I also don't like that double-meaning. That was the
> > reason why I originally proposed the use of a new parameter...
> > 
> 
> Ok, I have some patches to lifebook that I would like to included (if
> they work):
> 
> 1. lifebook-dmi-x86-only - do not compile in DMI detection on anything
>    but x86.

On !x86 machines DMI functions will be optimized away and so you'll save only
few bytes in .init.data section. IMHO it's not worth additional ugly #ifdef's.

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@xxxxxxxxx		| PGP key: wwwkeys.pgp.net

Attachment: signature.asc
Description: Digital signature