[PATCH][5/6] cifs: readdir.c cleanup - avoid needless casting

[Jesper Juhl]

Explicit casts between  type <whatever> and void  or to/from the 
same type is pointless.


Signed-off-by: Jesper Juhl <juhl-lkml@xxxxxx>

--- linux-2.6.12-rc1-mm1/fs/cifs/readdir.c.with_patch4	2005-03-22 20:45:09.000000000 +0100
+++ linux-2.6.12-rc1-mm1/fs/cifs/readdir.c	2005-03-22 20:46:03.000000000 +0100
@@ -37,7 +37,7 @@
 	struct cifsFileInfo *cf;
 
 	if (file) {
-		cf = (struct cifsFileInfo *)file->private_data;
+		cf = file->private_data;
 		if (cf == NULL) {
 			cFYI(1, ("empty cifs private file data"));
 			return;
@@ -292,7 +292,7 @@ static int initiate_cifs_search(const in
 	} else {
 		memset(file->private_data, 0, sizeof(struct cifsFileInfo));
 	}
-	cifsFile = (struct cifsFileInfo *)file->private_data;
+	cifsFile = file->private_data;
 	cifsFile->invalidHandle = TRUE;
 	cifsFile->srch_inf.endOfSearch = FALSE;
 
@@ -452,8 +452,7 @@ static int find_cifs_entry(const int xid
 	int pos_in_buf = 0;
 	loff_t first_entry_in_buffer;
 	loff_t index_to_find = file->f_pos;
-	struct cifsFileInfo *cifsFile =
-		(struct cifsFileInfo *)file->private_data;
+	struct cifsFileInfo *cifsFile = file->private_data;
 
 	/* check if index in the buffer */
 	if ((cifsFile == NULL) || (ppCurrentEntry == NULL) ||
@@ -799,7 +798,7 @@ int cifs_readdir(struct file *file, void
 			FreeXid(xid);
 			return rc;
 		}
-		cifsFile = (struct cifsFileInfo *)file->private_data;
+		cifsFile = file->private_data;
 		if (cifsFile->srch_inf.endOfSearch) {
 			if (cifsFile->srch_inf.emptyDir) {
 				cFYI(1, ("End of search, empty dir"));



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/