Re: repeat a function after fixed time period

From: Arjan van de Ven
Date: Wed Mar 23 2005 - 16:31:19 EST


On Wed, 2005-03-23 at 15:56 -0500, linux-os wrote:
> >> static void start_timer(void)
> >> {
> >> if(!atomic_read(&info->running))
> >> {
> >> atomic_inc(&info->running);
> >
> > same race.
>
> No such race at all.

here there is one; you use add_timer() which isn't allowed on running
timers, only mod_timer() is. So yes there is a race.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/