Re: drm bugs hopefully fixed but there might still be one..

From: Andrew Morton
Date: Thu Mar 24 2005 - 18:13:55 EST


cliff white <cliffw@xxxxxxxx> wrote:
>
> -extern struct agp_bridge_data *(*agp_find_bridge)(struct pci_dev *);
> -

Oh crap, so the compiler decided that agp_find_bridge() was a function and
decided to jump to it, rather than reading from it and doing an indirect
jump. Yup, that'll crash it. Sorry about that.

This is another reason why doing the old-style

(*agp_find_bridge)(...);

is better than doing the new-style

agp_find_bridge(...);

The former case won't even compile, and is more readable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/