Re: [PATCH] remove non-DISCONTIG use of pgdat->node_mem_map

[Martin J. Bligh]

> This patch effectively eliminates direct use of pgdat->node_mem_map
> outside of the DISCONTIG code.  On a flat memory system, these fields
> aren't currently used, neither are they on a sparsemem system.
> 
> There was also a node_mem_map(nid) macro on many architectures. Its
> use along with the use of ->node_mem_map itself was not consistent.
> It has been removed in favor of two new, more explicit,
> arch-independent macros:
> 
> 	pgdat_page_nr(pgdat, pagenr)
> 	nid_page_nr(nid, pagenr)
> 
> I called them "pgdat" and "nid" because we overload the term "node"
> to mean "NUMA node", "DISCONTIG node" or "pg_data_t" in very
> confusing ways.  I believe the newer names are much clearer.

Seems like a good plan - the abstraction will make it easier to change the
underlying mechanism. I'm not desperately keen on the new naming, but
given the current code state it makes sense, I guess. Once Andy has got
sparsemem merged up, and we change struct pgdat to be called struct node
or something more sensible, we can revisit it then.

Signed-off-by: Martin J. Bligh <mbligh@xxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/