[2.6 patch] drivers/input/joystick/spaceorb.c: fix an array overflow

From: Adrian Bunk
Date: Sun Mar 27 2005 - 15:40:58 EST


This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c.old 2005-03-23 02:12:33.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/input/joystick/spaceorb.c 2005-03-23 02:16:18.000000000 +0100
@@ -116,7 +116,7 @@ static void spaceorb_process_packet(stru

case 'K': /* Button data */
if (spaceorb->idx != 5) return;
- for (i = 0; i < 7; i++)
+ for (i = 0; i < 6; i++)
input_report_key(dev, spaceorb_buttons[i], (data[2] >> i) & 1);

break;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/