Re: [PATCH 2.6.11] aoe [7/12]: support configuration ofAOE_PARTITIONS from Kconfig

[Ed L Cashin]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> On Thu, Mar 24, 2005 at 07:21:28AM -0800, ecashin@xxxxxxxxxxxx wrote:
>> 
>> support configuration of AOE_PARTITIONS from Kconfig
>> 
>> Signed-off-by: Ed L. Cashin <ecashin@xxxxxxxxxx>
>> 
>> diff -uprN a/drivers/block/Kconfig b/drivers/block/Kconfig
>> --- a/drivers/block/Kconfig	2005-03-07 17:37:58.000000000 -0500
>> +++ b/drivers/block/Kconfig	2005-03-10 12:19:54.000000000 -0500
>> @@ -506,4 +506,19 @@ config ATA_OVER_ETH
>>  	This driver provides Support for ATA over Ethernet block
>>  	devices like the Coraid EtherDrive (R) Storage Blade.
>>  
>> +config AOE_PARTITIONS
>> +	int "Partitions per AoE device" if ATA_OVER_ETH
>> +	default "16"
>> +	help
>> +	  The default is to support 16 partitions per aoe device. Some
>> +	  systems lack good support for devices with large minor
>> +	  numbers.
>> +
>> +	  Such systems will be able to use more aoe disks when
>> +	  AOE_PARTITIONS is set to one, but you won't be able to
>> +	  partition the disks, and you must make sure your device
>> +	  nodes are created to work with the value you select.
>> +
>> +	  If unsure, use 16.
>> +
>
> NACK.  this changes devices nodes based on a compile-time option.  

I'm not sure I follow.  This configuration option sets the number of
partitions per device in the driver.  It doesn't create device nodes.

If the user has udev, then the device nodes are created correctly (on
Fedora Core 3), so that if the driver is configured with 1 partition
per device, the minor numbers for the disks are low.  

The folks I've talked to who aren't using udev but want one partition
per device already know that they have to re-create their device
files.

> Just tell people to update their userland to a 2.6-copatible
> version.

Even if the glibc, coreutils, etc., get it right, some programs try to
parse the device node bits themselves and fail to find all the minor
number bits.

Making this configurable makes it possible for a debian sarge user or
a Slackware 10 user to run a 2.6.11 kernel and use up to 256 disks.
Even a Fedora Core 3 user has an mdadm that balks at minor numbers
like 1120.  By using one partition per device, I can use FC3's mdadm
and have everything work.

The AoE users started doing this themselves, but this configuration
option allows non-C-programmers to do the same.  It's helpful during
the transitional period and should be removed when the userland
software that people are actually running has caught up.

-- 
  Ed L Cashin <ecashin@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/