Re: Do not misuse Coverity please

[Shankar Unni]

Jean Delvare wrote:

>     v = p->field;
>     if (!p) return;
>
> can be seen as equivalent to
>
>     if (!p) return;
>     v = p->field;

Heck, no.

You're missing the side-effect of a null pointer dereference crash (for 
p->field) (even though v is unused before the return). The optimizer is 
not allowed to make exceptions go away as a result of the hoisting.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/