Re: [patch 2/3] x86_64: remove duplicated sys_time64

[Andi Kleen]

On Thu, Mar 31, 2005 at 09:25:16PM +1000, Stephen Rothwell wrote:
> On Thu, 31 Mar 2005 13:12:35 +0200 Andi Kleen <ak@xxxxxxx> wrote:
> >
> > On Thu, Mar 31, 2005 at 09:10:59PM +1000, Stephen Rothwell wrote:
> > > On Thu, 31 Mar 2005 12:38:34 +0200 Andi Kleen <ak@xxxxxxx> wrote:
> > > >
> > > > Nack. The generic sys_time still writes to int, not long.
> > > > That is why x86-64 has a private one. Please keep that.
> > > 
> > > It writes to a time_t which is a __kernel_time_t which is a long on
> > > x86-64, isn't it?
> > 
> > At least in 2.6.10 it writes to int.
> 
> I was looking at current bk where it looks like this:
> 
> asmlinkage long sys_time(time_t __user * tloc)

Ok with that change the patch is ok.
> {
>         time_t i;
>         struct timeval tv;
> 
>         do_gettimeofday(&tv);
>         i = tv.tv_sec;
> 
>         if (tloc) {
>                 if (put_user(i,tloc))
>                         i = -EFAULT;
>         }
>         return i;
> }
> 
> I have no idea when it changed.
I was looking at an older tree, sorry.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/