Re: noresume breaks next suspend [was Re: 2.6.12-rc1 swsusp broken]

From: Nigel Cunningham
Date: Thu Mar 31 2005 - 19:49:28 EST


Hi.

On Fri, 2005-04-01 at 08:25, Pavel Machek wrote:
> Hi!
>
> > > Yes! With this it works ok.
> > >
> > > > Also, could you please try sticking psmouse_reset(psmouse) call at the
> > > > beginning of drivers/input/mouse/alps.c::alps_reconnect() and see if
> > > > it can suspend _without_ the patch above.
> > >
> >
> > Both patches are working for me (Dell D600). before i was unable to
> > suspend to disk on this laptop (it was stuck in alps code).
> >
> > By the way, i have an unrelated problem:
> > if the kernel was booted with the "noresume" option, it cannot be
> > suspended, it fails with:
> >
> > swsusp: FATAL: cannot find swap device, try swapon -a!
>
> Uh, okay, logic error, probably introduced by resume-from-initrd
> patch. Does this fix it?
>
> OTOH, perhaps refusing suspend is right thing to do. If user is
> running in "safe mode" (with noresume), we don't want him to be able
> to suspend...

What? If you suspend, then decide not to resume, you can suspend again
until after your next reboot?!

Nigel
--
Nigel Cunningham
Software Engineer, Canberra, Australia
http://www.cyclades.com
Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028; Mob: +61 (417) 100 574

Maintainer of Suspend2 Kernel Patches http://suspend2.net

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/