Re: [RFC,PATCH 3/4] Change synchronize_kernel to _rcu and _sched

From: Manfred Spraul
Date: Sat Apr 09 2005 - 13:43:23 EST




On Sat, 9 Apr 2005, Francois Romieu wrote:

> Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> :
> > [Jeff added to cc list - it's a network driver question]
> [...]
> > I haven't read the whole driver, but what about
> > spin_unlock_wait(&dev->xmit_lock);
> > ?
>
> The race here is a dev->close() against dev->hard_start_xmit() one where
> dev->hard_start_xmit() does not do any locking at all.
>
I always thought that all callers of dev->hard_start_xmit() acquire
dev->xmit_lock before calling hard_start_xmit().

Is that assumption wrong? I think I even rely on that in one of my
drivers.

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/