Re: [PATCH 2.6.11.7 1/1] x86 reboot: Add reboot fixup for gx1/cs5530a

[H. Peter Anvin]

jayalk@xxxxxxxxxxxx wrote:
> Hi Riley, Dave, Peter, i386 boot/workaround maintainers,
>
> I'm resending this patch (from March 28). 
>
> This patch incorporates the suggestions from the previous thread and also
> switches to using pci_get_device since pci_find_device is deprecated, and
> made some of the variables static.
>
> Please let me know if it's okay.

> +#define mach_reboot_fixups(x) do {} while (0)

As I stated last time, this should be:

#define mach_reboot_fixup(x)	((void)(x))

... to preserve side effects, and be expression-like.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/