Re: [PATCH] Fix floppy disk dependencies

From: Al Viro
Date: Tue Apr 12 2005 - 11:59:02 EST


On Mon, Apr 11, 2005 at 11:15:20PM +0100, Russell King wrote:
> Both the RiscPC and (optionally) EBSA285 have floppy disk
> support. Allow this option to be selected on these ARM
> platforms again.

I think it's a wrong approach. Instead of this collection of
dependencies we should bite the bullet and put

config HAS_GENERIC_FDC
bool
default y

in arch/*/Kconfig of platforms that do have it and

config BLK_DEV_FD
tristate "Normal floppy disk support"
depends on HAS_GENERIC_FDC

in drivers/block/Kconfig. That way we can express such dependencies
sanely without bringing all the gory details in one pile.

I'll do that unless there are serious objections...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/