Re: [PATCH] hangcheck-timer: Update to 0.9.0.

[Andrew Morton]

Joel Becker <Joel.Becker@xxxxxxxxxx> wrote:
>
> +#if defined(__i386__) || defined(__x86_64__)
> +# define HAVE_MONOTONIC
> +# define TIMER_FREQ 1000000000ULL
> +#elif defined(__s390__)
> +/* FA240000 is 1 Second in the IBM time universe (Page 4-38 Principles of Op for zSeries */
> +# define TIMER_FREQ 0xFA240000ULL
> +#elif defined(__ia64__)
> +# define TIMER_FREQ ((unsigned long long)local_cpu_data->itc_freq)
> +#elif defined(__powerpc64__)
> +# define TIMER_FREQ (HZ*loops_per_jiffy)
> +#endif  /* __s390__ */

It's not very important, but it would be a bit more conventional to use
CONFIG_X86, CONFIG_ARCH_S390, CONFIG_IA64 and CONFIG_PPC64 for those cases
where such an ifdef is to be used.

In the above case specifically, no ifdefs should be needed - you can simply
define CONFIG_HANGCHECK_TIMER_FREQ in arch/*/Kconfig.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/