Re: [2.6 patch] fs/udf/inode.c: fix a check after use

From: Al Viro
Date: Tue Apr 12 2005 - 22:11:40 EST


On Wed, Apr 13, 2005 at 04:17:37AM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.

Bullshit. *Please*, read the surrounding code. Again, we never get
to calling that function if we would pass NULL in its first argument.

It's BUG_ON(), not printk(). And oops on entering the function in
question is just as good as BUG_ON(). Remove check and be done with
that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/