Re: [PATCH] hpt366: HPT372N rev 2 controller fix

[Alan Cox]

On Iau, 2005-04-21 at 06:54, Albert Lee wrote:
> A particular revision of the HPT372N oopses hpt366 consistently. It's a 
> regression caused by Alan's changes in 2.6.9 to support the HPT372N using 
> only PLL timings. The driver works correctly in prior versions, where the the 
> PCI clock is used instead. This patch restores that behaviour for this 
> particular revision.

For some drives, if you are lucky. The problem is that the PLL code in
the hpt366 driver is simply wrong. The -ac tree has some cleanup work in
this area but hasn't fixed the PLL code yet. The vendor driver does
handle this chip correctly.

Linus please avoid this patch - better an oops than disk corruption.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/