Re: [PATCH] swsusp: misc cleanups [4/4]

[Pavel Machek]

Hi!

> >> The following patch makes some comments and printk()s in swsusp.c up to date.
> >> In particular it adds the string "swsusp" before every message that is printed by
> >> the code in swsusp.c.
> > 
> > I don't like this one. Adding swsusp everywhere just clutters the
> > screen, most of it should be clear from context.
> 
> I like it. The messages are short enough so we should not get line wraps
> and it makes stuff more clear. You know, the context is not familiar to
> everyone, just imagine the "why do we {suspend,resume} devices during
> {resume,suspend} questions.
> 
> Also, i can ask for "send me output of dmesg|grep ^swsusp" to avoid
> newbies flooding me with totally irrelevant info ;-)

That would not work, anyway. You want the messages from drivers,
too... and drivers are not going to prepend "swsusp".

Ultimately, cleaning up "suspend screen" so that it is not too scary
for non-technical users might be nice... It means killing some debug
messages from drivers, too.

					 			Pavel
-- 
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/