Re: [RFC][PATCH] update SubmittingPatches to clarify attachment policy

From: Steven Cole
Date: Thu May 05 2005 - 16:36:18 EST


Paulo Marques wrote:
Krzysztof Halasa wrote:

Rik van Riel <riel@xxxxxxxxxx> writes:


The problem is replying to an attachment. The reason why having
the patch in the main mail body is good is that it gets quoted
by the email software and you can easily reply to individual
parts of the patch.



If the attachment is "disposition=inline", does the problem still exist?


I've just checked this with Thunderbird (which is the mail client I use).

It not only sets the disposition=inline by default when attaching patches, it also places the patch inline when replying to it, allowing the user to write between the text of the patch as if it were part of the email text.

However if we Copy+Paste the patch into the mail it gets line wrapped / white space mangled.

That depends on where you are Copy+Pasting from. Granted, Copy+Paste from
a variety of sources is a nightmare. But, Copy+Paste from Tbird to Tbird
seems to actually work.


So at least for Thunderbird users it would be better to use attached patches with "Content-Disposition: inline".


Here is a trick you can play with Thunderbird to get inlined patches:

1) Mail the patch to yourself as an attachment.
2) Read the mail you just got, copy and paste the patch to your new message.

This method preserves the tabs/whitespace. Of course, you have to set the
wordwrap settings appropriately. It works for me.

Steven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/