Re: [uClinux-dev] [PATCH 4/4] nommu - backward compatibility patchfor mm/nommu.c

[Greg Ungerer]

David Howells wrote:
> Hyok S. Choi <hyok.choi@xxxxxxxxxxx> wrote:
>
>
> > -		    (*parent)->vma->vm_end == end)
> > +		    (!len || (*parent)->vma->vm_end == end))
>
>
> Please make this configurable. It's bypassing an error case check.

I disagree, I don't think it warrents yet another configuration option.

Most uClinux archiectures don't want to do this size error check - at
least any that rely on the current implementation of light weight uClibc
mmap() based malloc(). And up until recently this was _every_ uClinux
architecture.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@xxxxxxxxxxxx
SnapGear -- a CyberGuard Company            PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/