Re: [PATCH] __wait_on_freeing_inode fix

[William Lee Irwin III]

On Fri, May 06, 2005 at 01:46:38PM +0200, Miklos Szeredi wrote:
> If I_LOCK was not set it called yield(), effectively busy waiting for
> the removal of the inode from the hash.  This change was introduced
> within "[PATCH] eliminate inode waitqueue hashtable" Changeset
> 1.1938.166.16 last october by wli.
> The solution is to restore the old behavior, of unconditionally
> waiting on the waitqueue.  It doesn't matter if I_LOCK is not set
> initally, the task will go to sleep, and wake up when wake_up_inode()
> is called from generic_delete_inode() after removing the inode from
> the hash chain.

I was trying to preserve some (possibly misinterpreted) behavior but I
can't remember what anymore. Anyway, since it's misbehaving, nuke it.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/