Re: [RFC/PATCH 2/5] mm/fs: add execute in place support

[Matthew Wilcox]

On Wed, May 11, 2005 at 04:30:15PM +0200, Carsten Otte wrote:
> +	BUG_ON(!mapping->a_ops->get_xip_page);

No need to put this assert here.  You'll get exactly as good a stack trace ...

> +		page = mapping->a_ops->get_xip_page(mapping,
> +			index*(PAGE_SIZE/512), 0);

... here, when you call through a null pointer.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/