Re: [RFC][PATCH] timers fixes/improvements

[Ganesh Venkatesan]

John Linville, who originally proposed the patch (to add
e1000_watchdog_task and related code) has since withdrawn the patch.

e1000_down may still be suffering from the del_timer_sync race
condition that Oleg identified at the start of this thread.

ganesh.

On 5/11/05, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> Btw, i think that drivers/net/e1000/e1000_main.c:e1000_down() is buggy.
> 
> It calls del_timer_sync(&adapter->watchdog_timer), but e1000_watchdog()
> calls schedule_work(e1000_watchdog_task), so the work could be queued
> after del_timer_sync().
> 
> And e1000_watchdog_task() arms timers again.
> 
> Note that it's not enough to do flush_scheduled_work() here.
> 
> Oleg.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/