Re: [RFC: 2.6 patch] ext2: make ext2_count_free a static inline

[Andrew Morton]

Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
>  --- linux-2.6.12-rc2-mm3-full/fs/ext2/ext2.h.old	2005-04-20 23:08:52.000000000 +0200
>  +++ linux-2.6.12-rc2-mm3-full/fs/ext2/ext2.h	2005-04-20 23:14:21.000000000 +0200
>  @@ -1,5 +1,6 @@
>   #include <linux/fs.h>
>   #include <linux/ext2_fs.h>
>  +#include <linux/buffer_head.h>
>   
>   /*
>    * second extended file system inode data in memory
>  @@ -79,6 +80,22 @@
>   	return container_of(inode, struct ext2_inode_info, vfs_inode);
>   }
>   
>  +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0};
>  +

This will cause a copy of `nibblemap' to be included in each compilation
unit which uses ext2.h.  Unless the compiler is sufficiently smart to elide
it, which it might be.  But then it might be sufficiently smart to generate
a "you're not usig this" warning too.

If it's only needed for EXT2_DEBUG then I'd be inclined to move it into one
of the other .c files, inside EXT2_DEBUG.  Or just leave it as-is.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/