Re: [PATCH] NMI lockup and AltSysRq-P dumping calltraces on _all_ cpus via NMI IPI

From: Martin J. Bligh
Date: Mon May 16 2005 - 17:41:10 EST


--On Wednesday, May 11, 2005 19:57:19 +0400 Kirill Korotaev <dev@xxxxx> wrote:

> against 2.6.12-rc4
>
> This patch adds dumping of calltraces on _all_ CPUs
> on AltSysRq-P and NMI LOCKUP. It does this via sending
> NMI IPI interrupts to the cpus.
>
> I saw the same patch in RedHat kernels, here goes our own version of the patch, not sure it will be accepted, but I think it can be used by some people at least for debugging lockups etc.

I'd done a similar thing, but just using smp_call_function (I hacked the
interrupt routine to fish pt_regs back out, and override *info in some
cases). Doing NMIs, as you've done, is probably nicer, but a lot more
work.

The problem with it (and my patch too) is that you're hooking into arch
specific code from generic code, which means you'll break every other
arch apart from i386. Fixing this is a pain in the rear end, but would
be needed to merge the patch. OTOH, the patch is extremely useful, so
would be nice to fix if you have the energy ...

M.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/