Re: Illegal use of reserved word in system.h

[Andi Kleen]

"Gilbert, John" <JGG@xxxxxxxxx> writes:
>
> I think it's been in there a while, but only really blows up when built
>
> under recent kernels.
>
> I agree, it's probably not the right way to go.

It's quite dangerous. I suppose it uses this for atomic.h, but it
means that a mysql compiled under a uniprocessor kernel (or rather
with a autoconf.h of a uniprocessor kernel, it can even be SMP) will
have subtle races when run on a SMP system because the atomic
instructions will miss lock prefixes. Sounds like an open
deathtrap to me.

I would suggest changing MySQL to keep its own copies of atomic.h
for the different architectures. Then they can drop the asm/system.h
includes too.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/