[PATCH] BUG_ON() in ksoftirqd is a bit too agressive...

[George Anzinger]

Ksoftirqd is created by init, long after the timer system is up and running.  We 
have hit the BUG_ON(tasklet_... in this code, i.e. tasklets pending at ksoftirqd 
create time.  Since, with the RT option to push all softirq code to a thread, 
any softirqs are defered to this time, it is easy to hit this bug.  Clearly only 
a problem for cpu 0.  Here is a patch:


Index: linux-2.6.10/kernel/softirq.c
===================================================================
--- linux-2.6.10.orig/kernel/softirq.c
+++ linux-2.6.10/kernel/softirq.c
@@ -514,8 +514,12 @@

 	switch (action) {
 	case CPU_UP_PREPARE:
-		BUG_ON(per_cpu(tasklet_vec, hotcpu).list);
-		BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
+		/* We may have tasklets already scheduled on
+		   processor 0, so don't check there. */
+		if (hotcpu != 0) {
+			BUG_ON(per_cpu(tasklet_vec, hotcpu).list);
+			BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
+		}
 		p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu);
 		if (IS_ERR(p)) {
 			printk("ksoftirqd for %i failed\n", hotcpu);
--
George Anzinger   george@xxxxxxxxxx
High-res-timers:  http://sourceforge.net/projects/high-res-timers/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/