Re: [RFC][PATCH] rbind across namespaces

From: Ram
Date: Sun May 22 2005 - 16:12:20 EST


On Sun, 2005-05-22 at 01:08, Miklos Szeredi wrote:
> > > I still see a problem: what if old_nd.mnt is already detached, and
> > > bind is non-recursive. Now it fails with EINVAL, though it used to
> > > work (and I think is very useful).
> >
> > Hey, you just made another argument for not detaching mounts when the
> > last task with that current->namespace exits, but instead detaching
> > mounts when the last reference to any vfsmnt in the namespace is dropped.
> >
> > Hint :)
>
> I have a better idea:
>
> - create a "dead_mounts" namespace.
> - chain each detached mount's ->mnt_list on dead_mounts->list
> - set mnt_namespace to dead_mounts
> - export the list via proc through the usual mount list interface
>
> The last would be a nice bonus: I've always wanted to see the list of
> detached, but not-yet destroyed mounts.
>
> Does anybody see a problem with that?


Yes. :) because I will have to change my 'rbind across namespace' patch
because now detached mounts will have dead_mounts namespace instead of
null namespace.

RP


>
> Miklos

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/