Re: [V9fs-developer] Re: [RFC][patch 3/7] v9fs: VFS inode operations(2.0-rc6)

From: Miklos Szeredi
Date: Tue May 24 2005 - 09:27:13 EST


> The reason I prefer the 'retval = blah blah; return retval;' usage is that
> I frequently have run v9fs in UML, and debugging is just easier. Set the
> breakpoint in v9fs_vfs_create, step through, maybe skip over that
> v9fs_create function, look at retval.

Why don't you just use 'finish'. That prints the return value.

Every unnecessary line in a function makes it harder to read. That
includes over-commenting and overuse of empty lines.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/