Re: [Fastboot] [1/2] kdump: Use real pt_regs from exception

[Alexander Nyberg]

ons 2005-05-25 klockan 18:36 +0530 skrev Vivek Goyal:
> On Wed, May 25, 2005 at 02:14:56PM +0200, Alexander Nyberg wrote:
> > ons 2005-05-25 klockan 02:07 -0700 skrev Andrew Morton:
> > > Alexander Nyberg <alexn@xxxxxxxxx> wrote:
> > > >
> > > > -extern void machine_crash_shutdown(void);
> > > >  +extern void machine_crash_shutdown(struct pt_regs *);
> > > 
> > > That'll break x86_64, ppc, ppc64 and s/390.
> > 
> > I'm such an idiot.
> > 
> > Make sure all arches take pt_regs * as argument to
> > machine_crash_shutdown(). (now cross-compiled on above arches except
> > s/390).
> > 
> 
> Alexander, I face following warning if I build my kernel without HIGHMEM
> support. Fianally linker fails in the end.
> 
> CC      kernel/kexec.o
> kernel/kexec.c: In function `kexec_should_crash':
> kernel/kexec.c:37: warning: implicit declaration of function `in_interrupt'
> 
> If I include HIGHMEM support, it compiles fine.
> 
> You might have to include include/linux/hardirq.h in kexec.c to 
> resolve the problem.
> 

Yeah this is fixed in -mm, thanks


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/