Re: [PATCH] show swsuspend only on .config where it can compile

From: Romano Giannetti
Date: Thu May 26 2005 - 07:50:44 EST


On Thu, May 26, 2005 at 01:16:14PM +0200, Olaf Hering wrote:
> show swsuspend only on .config where it can compile.
> I got this on PPC32 && SMP
>
> kernel/power/smp.c:24: error: storage size of `ctxt' isn't known
>
> Signed-off-by: Olaf Hering <olh@xxxxxxx>
>
> Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.12-rc5-olh.orig/kernel/power/Kconfig
> +++ linux-2.6.12-rc5-olh/kernel/power/Kconfig
> @@ -28,7 +28,7 @@ config PM_DEBUG
>
> config SOFTWARE_SUSPEND
> bool "Software Suspend (EXPERIMENTAL)"
> - depends on EXPERIMENTAL && PM && SWAP
> + depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)

Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP ) ?

and maybe

EXPERIMENTAL && PM && SWAP && ( X86 || ((FVR || PPC32) && !SMP) )

is clearer?



--
Romano Giannetti - Univ. Pontificia Comillas (Madrid, Spain)
Electronic Engineer - phone +34 915 422 800 ext 2416 fax +34 915 596 569
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/